Use subscription of the product class #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use add_on check that would return the real product class, instead of the wrong base product With that add_on product class value, perform the query to fetch the proper subscription for the product Do not compare product identifiers or based product classes but product class which belong to the right subscription This Fixes bsc#1236816 and bsc#1236836
rjschwei
requested changes
Feb 6, 2025
engines/instance_verification/lib/instance_verification/providers/example.rb
Show resolved
Hide resolved
rjschwei
approved these changes
Feb 7, 2025
digitaltom
reviewed
Feb 8, 2025
engines/instance_verification/lib/instance_verification/engine.rb
Outdated
Show resolved
Hide resolved
digitaltom
reviewed
Feb 8, 2025
engines/instance_verification/lib/instance_verification/providers/example.rb
Show resolved
Hide resolved
digitaltom
reviewed
Feb 8, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use add_on check that would return the real product class, instead of the wrong base product
With that add_on product class value, perform the query to fetch the proper subscription for the product
Do not compare product identifiers or based product classes but product class which belong to the right subscription
This Fixes bsc#1236816 and bsc#1236836
How to test
Migrate a Micro 5.5 -> Micro 6.1 should succeed
Change Type
Please select the correct option.
Checklist
Please check off each item if the requirement is met.
MANUAL.mdfile with any changes to the user experience.package/obs/rmt-server.changes.Review
Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.